Fix malformed QMDL manifest writes #225
Open
+18
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix EFForg#199 Fix EFForg#151 rayhunter updates manifest files using write **without truncation**. This means that if the new manifest is shorter than the old one, trailing bytes of the old data will persist in the new file. Switch over to atomic file writes so that this bug is fixed + rayhunter behaves correctly if it is killed mid-write. EFForg#182 could be reverted as it seems to mostly be a workaround.
untitaker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #199
Fix #151
rayhunter updates manifest files using write without truncation.
This means that if the new manifest is shorter than the old one,
trailing bytes of the old data will persist in the new file.
Switch over to atomic file writes so that this bug is fixed + rayhunter
behaves correctly if it is killed mid-write.
The changes in
RecordingStore::createare just to ensure that allwriting of the manifest goes through
write_manifest.#182 could be reverted as it
seems to mostly be a workaround.