Remove the quarantine bit from the serial command on macOS #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good. And yes, that is exactly the issue I had/fix I used. |
|
This looks fine to me in theory. I will test it ASAP. |
|
this looks great! Unfortunately there is a merge conflict here because i just merged another change that moved the install-linux and install-mac files into a unified install script. If you can update your changes for the latest HEAD of main I would appreciate it and be happy to accept this PR. |
kstrauser
force-pushed
the
ks-mac-attr-fix
branch
from
0ea2db4 to
f6af859
Compare
|
Hey @cooperq, I've rebased it off the new combined script now. |
wgreenberg
approved these changes
Mar 20, 2025
|
thanks @kstrauser! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
serial-macos-latest/serialcommand in the installer bundle has the quarantine bit set. This unsets that attribute so that macOS doesn't throw an error message likeThis is the same error message @jullrich saw in #149. This fixes it. After the change, the installer script runs to completion on my M2 MacBook Air running macOS 15.3.2.