-
-
Notifications
You must be signed in to change notification settings - Fork 410
Fix tab order on tracking domains setting page and remove float layout #3122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix tab order on tracking domains setting page and remove float layout #3122
Conversation
Previously the tab order in the list of tracking domains was: domain, x-Button, toggle. Now, the order is as expected: domain, toggle, x-Button. This was achieved by changing the order of the DOM nodes inside a tracking domain row. The layout was then fixed by replacing the float layout with some grid and flex layouts to have a more robust layout with fewer magic numbers. Fixes EFForg#3107
Thank you!! I will be able to review your contribution mid next week. |
A couple of our functional tests are failing. I wonder if it's because the tests need to be updated (probably because the selectors changed) or if they flagged a regression. |
Oh.. yes, that could be a problem with the selectors. I can have a look on the tests next week. |
@BeniRupp I'm holding off looking further until you had a chance to respond to our initial feedback. Let us know if you have any questions please. |
Let us know if you have any questions about our feedback. Thanks again for contributing! |
This comment was marked as off-topic.
This comment was marked as off-topic.
@itlinuxmaker I think the requirement not to change the layout is an acceptable requirement for a UI application. Furthermore, the tests are also broken. So we definitly have to rework the PR. @ghostwords @lenacohen Unfortunately, I don't have much time at the moment and won't be able to continue working on the ticket anytime soon. If it's okay with you, I'll be happy to take another look at it in 3-4 weeks. |
This comment was marked as off-topic.
This comment was marked as off-topic.
@itlinuxmaker Providing, accepting and acting on feedback is a standard part of software development. Furthermore, please note that this project is governed by the EFF Public Projects Code of Conduct. Specifically:
|
@BeniRupp No problem, thanks for letting us know! We'll keep this open until the bug gets fixed here or elsewhere. |
Previously the tab order in the list of tracking domains was: domain, x-Button, toggle.
Now, the order is as expected: domain, toggle, x-Button. This was achieved by changing the order of the DOM nodes inside a tracking domain row. The layout was then fixed by replacing the float layout with some grid and flex layouts to have a more robust layout with fewer magic numbers.
Fixes #3107
This PR was part of the Hackergarten Stuttgart (Hack no. 427).
Co-authored by @itlinuxmaker