Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for gzipped ontologies (#761) #762

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

add support for gzipped ontologies (#761) #762

wants to merge 3 commits into from

Conversation

jamesamcl
Copy link
Member

No description provided.

@henrietteharmse
Copy link
Collaborator

James, have you tested this on dev?

@jamesamcl
Copy link
Member Author

No just locally. Maybe we can merge it into dev and try it?

@henrietteharmse
Copy link
Collaborator

henrietteharmse commented Dec 11, 2024

No, you can deploy the branch on dev and test it. We tend to first test on dev before we merge into dev. In the pipeline you can state which branch to deploy.

Apologies, BTW. I somehow missed the PR review request. I usually try to do it ASAP. If I do not respond in a day, shout at me.

@henrietteharmse
Copy link
Collaborator

Ensure though that latest changes from dev has been merged into your branch.

@haideriqbal
Copy link
Collaborator

FYI to test a branch on dev env you need to change branch name and image tag(which is your branch name) in attached jenkins step.

Screenshot 2024-12-11 at 10 37 31
Screenshot 2024-12-11 at 10 37 44
Screenshot 2024-12-11 at 10 37 53

@haideriqbal
Copy link
Collaborator

@jamesamcl bringing this up your radar... has this been tested on dev?

@jamesamcl
Copy link
Member Author

Tested on dev and causes issues with 17 ontologies

afpo
dcat
dicom
emi
lipidmaps
ogg
ordo
orth
owl
phi
probonto
rdfs
slm
slso
snomed
teddy
uniprotrdfs

investigating why

@jamesamcl jamesamcl self-assigned this Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants