Bring in fixes to barotropic steamfunciton from mpas_tools
#285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just for added clarity
Among other things, this bring in fixes to the computation of the batotropic streamfunction.
xylar
added
bug
TestingWhile an MPAS-Tools release is needed for this to be ready, I tested the barotrppic gyre with this branch and MPAS-Dev/MPAS-Analysis#1069. This branch: Previous result (less noisy before the switch to mosaic): It is hard to tell because of the dynamic bounds on the plots but the results seem to be similar. The fixes to the BSF are likely primarily relevant for setups with multiple, disconnected boundaries with non-negligible volume transport between them (e.g. the Drake Passage). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See MPAS-Dev/MPAS-Analysis#1069 and MPAS-Dev/MPAS-Tools#607 for details on the fixes to the BSF.
Checklist
Testingcomment in the PR documents testing used to verify the changes