i#7464 msb memref: Allow non-memref to follow prefetch instr#7465
Draft
abhinav92003 wants to merge 15 commits intomasterfrom
Draft
i#7464 msb memref: Allow non-memref to follow prefetch instr#7465abhinav92003 wants to merge 15 commits intomasterfrom
abhinav92003 wants to merge 15 commits intomasterfrom
Conversation
Allows raw traces entries that do not look like OFFLINE_TYPE_MEMREF or OFFLINE_TYPE_MEMREF_HIGH to follow prefetch instructions during raw2trace conversion. Prefetch instructions may generate a memref with an address that has some of the top 3 bits set which overwrites the type field to contain a value that is not either OFFLINE_TYPE_MEMREF or OFFLINE_TYPE_MEMREF_HIGH. Here, we override raw2trace logic to force it to process the raw trace entry following a prefetch instruction as a memref. raw2trace conversion of a real trace failed with the "Unknown trace type" error without this fix. Reproduces the same issue on the builtin_prefetch app, which is now fixed. Issue: #7464
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows raw traces entries that do not look like OFFLINE_TYPE_MEMREF or OFFLINE_TYPE_MEMREF_HIGH to follow prefetch instructions during raw2trace conversion.
Prefetch instructions may generate a memref with an address that has some of the top 3 bits set which overwrites the type field to contain a value that is not either OFFLINE_TYPE_MEMREF or OFFLINE_TYPE_MEMREF_HIGH. Here, we override raw2trace logic to force it to process the raw trace entry following a prefetch instruction as a memref.
raw2trace conversion of a real trace failed with the "Unknown trace type" error without this fix. Reproduces the same issue on the builtin_prefetch app, which is now fixed.
Issue: #7464, #7364