Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#7303 drsyscall: copy drsyscall test files. #7403

Merged
merged 7 commits into from
Mar 27, 2025

Conversation

ivankyluk
Copy link
Contributor

@ivankyluk ivankyluk commented Mar 27, 2025

Copy DrSyscall tests from DrMemory to DynamoRIO.

These are tests in DrMemory test which use DrSyscall:

  • drsyscall_test
  • strace_sample
  • strace_test

The following files are copied from DrMemory to DynamoRIO for the tests:

  • drmemory/framework/samples/strace.c -> dynamorio/api/samples/strace.c
  • drmemory/tests/framework/strace_client.c -> dynamorio/suite/tests/client-interface/strace_client.c
  • drmemory/tests/framework/drsyscall_app.c -> dynamorio/suite/tests/client-interface/drsyscall_app.c
  • drmemory/tests/framework/drsyscall_client.c -> dynamorio/suite/tests/client-interface/drsyscall_client.c

A follow up PR will change the names of these files to be more consistent with DynamoRIO and fix formatting issues.

Issue: #7303

@ivankyluk ivankyluk changed the title i#7303 drsyscall: copy drsyscall tests. i#7303 drsyscall: copy drsyscall test files. Mar 27, 2025
@ivankyluk ivankyluk marked this pull request as ready for review March 27, 2025 18:18
@ivankyluk ivankyluk requested a review from derekbruening March 27, 2025 18:18
@ivankyluk ivankyluk merged commit d738932 into master Mar 27, 2025
24 checks passed
@ivankyluk ivankyluk deleted the i7303-copy-drsyscall-tests branch March 27, 2025 21:09
ivankyluk added a commit that referenced this pull request Apr 1, 2025
)

Add DrSyscall tests to DynamoRIO for Linux x86 CI tests.

#7403 Copied the test files from DrMemory to DynamoRIO. This PR makes
the following changes to add the tests to Linux x86 CI:

- run clang-format on the test files.
- rename suite/tests/client-interface/drsyscall_app.c to
drsyscall-test.c.
- rename suite/tests/client-interface/drsyscall_client.c to
suite/tests/client-interface/drsyscall-test.dll.c.
- rename suite/tests/client-interface/strace_client.c to
suite/tests/client-interface/strace-test.dll.c.
- change PAGE_SIZE to dr_page_size() in strace-test.dll.c and
drsyscall-test.dll.c.
- add statx entry in ext/drsyscall/table_linux.c which is required for
ci-x86/x86-32.
- add drsyscall_test, strace_sample, and strace_test to
suite/tests/CMakeLists.txt.
- add expect files for the new tests.

drsyscall_test, strace_sample, and strace_test fail on Windows due to
syscall mismatch in drsyscall_os_init().

Issue: #7303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants