i#7363: fix exclusive mode cache policy #7398
Merged
+286
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the problem of exclusive mode caches not properly updating state related to cache policies. The problem was exposed by recent updates to the drcachesim cache policy logic that made policy updates much more explicit. Several situations were identified by inspection in which exclusive caches did not update the policy counters properly. This update fixes the problem, and adds two new tests to exercise the exclusive cache policy interactions. Also included is a minor error check in get_cache_metric() to help users avoid wasting hours debugging phantom cache problems because they incorrectly expect cache levels to start at zero. Fixes: #7363
derekbruening
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem of exclusive mode caches not properly updating state related to cache policies.
The problem was exposed by recent updates to the drcachesim cache policy logic that made policy updates much more explicit. Several situations were identified by inspection in which exclusive caches did not update the policy counters properly.
This update fixes the problem, and adds two new tests to exercise the exclusive cache policy interactions. Also included is a minor error check in get_cache_metric() to help users avoid wasting hours debugging phantom cache problems because they incorrectly expect cache levels to start at zero.
Fixes: #7363