Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i#4103 clang-tidy: Fix clang-tidy warnings #7397

Merged
merged 1 commit into from
Mar 24, 2025
Merged

i#4103 clang-tidy: Fix clang-tidy warnings #7397

merged 1 commit into from
Mar 24, 2025

Conversation

derekbruening
Copy link
Contributor

Fixes 3 clang-tidy warnings:

  • Removes default parameter value on virtual function schedule_stats_t::create_histogram()
  • Fixes inconsistent parameter name in is_annotation_tag()
  • Adds missing annotations_api.h header

Issue: #4103, #7355

@derekbruening
i#4103 clang-tidy: Fix clang-tidy warnings
7351d63 
Fixes 3 clang-tidy warnings:
+ Removes default parameter value on virtual function
  schedule_stats_t::create_histogram()
+ Fixes inconsistent parameter name in is_annotation_tag()
+ Adds missing annotations_api.h header

Issue: #4103, #7355
@derekbruening derekbruening requested a review from edeiana March 24, 2025 20:04
@derekbruening derekbruening merged commit 4ba7199 into master Mar 24, 2025
24 checks passed
@derekbruening derekbruening deleted the i4103-clang-tidy branch March 24, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeiana edeiana edeiana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekbruening @edeiana