i#7355 per-sys-stats: Add per-syscall-number whether-switch latency histograms #7391
+275
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istograms Augments the schedule_stats drmemtrace tool to keep two histograms for each system call number: one for latencies of system calls causing a context switch, and one for latencies not switching. Unfortunately the latencies are all 0 for core-sharded-on-disk traces; we live with that for now. Generalizes the histogram support through virtual methods create_histogram() and find_or_add_histogram() to make it easier to use different histograms in subclasses with all the new histograms being added here. Adds a unit test and augments top-level test expected output. Fixes #7355
abhinav92003
approved these changes
Mar 21, 2025
…nt; add clarifying comments in multiple places
|
x86-32 failure is a flake: sample.callstack on new ub22. Filed #7394. Re-running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augments the schedule_stats drmemtrace tool to keep two histograms for each system call number: one for latencies of system calls causing a context switch, and one for latencies not switching. Unfortunately the latencies are all 0 for core-sharded-on-disk traces; we live with that for now.
Generalizes the histogram support through virtual methods create_histogram() and find_or_add_histogram() to make it easier to use different histograms in subclasses with all the new histograms being added here.
Adds a unit test and augments top-level test expected output.
Fixes #7355