i#7360: Fix ldscript creation with binutils 2.44 and preferred base set #7369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to adjust current location pointer to our preferred base address
at start of the linkscript, which creates a hole in the address space
and allows the linker to put the ELF header and other sections before
address of __executable_start symbol. This causes assertion failures
when building with binutils 2.44,
Internal Error: DynamoRIO debug check failure:
/dynamorio/core/unix/os.c:9618 check_start == dynamo_dll_start
Since binutils ld.bfd always determines the base address by
. = SEGMENT_START("text-segment", 0x400000) + SIZEOF_HEADERS;
starting from at least 2003, it should be fine to drop the extra
adjustment and only replace the default base with our preferred base.
Fixes: DynamoRIO#7360
derekbruening
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to adjust current location pointer to our preferred base address at start of the linkscript, which creates a hole in the address space and allows the linker to put the ELF header and other sections before address of __executable_start symbol. This causes assertion failures when building with binutils 2.44,
Since binutils ld.bfd always determines the base address by
starting from at least 2003, it should be fine to drop the extra adjustment and only replace the default base with our preferred base.
Fixes: #7360