i#7334: Set package name for on-arm builds #7335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today the package platform name assumes x86 and is overridden for cross-compile jobs only in package.cmake. So a package build on an arm machine has an x86 name like 'DynamoRIO-x86_64-Linux-11.90.20152.tar.gz". We fix that here to support building packages on arm machines directly. Tested on an aarch64 machine where this fix produces the name "DynamoRIO-AArch64-Linux-11.90.20152.tar.gz". Fixes #7334
ivankyluk
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the package platform name assumes x86 and is overridden for cross-compile jobs only in package.cmake. So a package build on an arm machine has an x86 name like 'DynamoRIO-x86_64-Linux-11.90.20152.tar.gz".
We fix that here to support building packages on arm machines directly. Tested on an aarch64 machine where this fix produces the name "DynamoRIO-AArch64-Linux-11.90.20152.tar.gz".
Fixes #7334