Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package built on arm machine has x86 name #7334

Closed
derekbruening opened this issue Mar 6, 2025 · 0 comments · Fixed by #7335
Closed

Package built on arm machine has x86 name #7334

derekbruening opened this issue Mar 6, 2025 · 0 comments · Fixed by #7335
Assignees
@derekbruening
Labels
Component-Build OpSys-AArch64 OpSys-ARM

Comments

@derekbruening
Copy link
Contributor

I built a package on an aarch64 machine but the name has x86-64 in it:

DynamoRIO-x86_64-Linux-11.90.20152.tar.gz

Looks like the package naming code only sets for arm variants when doing cross-compiles.
@derekbruening derekbruening self-assigned this Mar 6, 2025
derekbruening added a commit that referenced this issue Mar 6, 2025
@derekbruening
i#7334: Set package name for on-arm builds
26d5861 
Today the package platform name assumes x86 and is overridden for
cross-compile jobs only in package.cmake. So a package build on an arm
machine has an x86 name like 'DynamoRIO-x86_64-Linux-11.90.20152.tar.gz".

We fix that here to support building packages on arm machines directly.
Tested on an aarch64 machine where this fix produces the name
"DynamoRIO-AArch64-Linux-11.90.20152.tar.gz".

Fixes #7334
@derekbruening derekbruening mentioned this issue Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbruening derekbruening

Labels
Component-Build OpSys-AArch64 OpSys-ARM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#7334: Set package name for on-arm builds DynamoRIO/dynamorio
1 participant
@derekbruening