Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#2190: Fix a typo of identical conditions #2545

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

Artem-OSSRevival
Copy link
Contributor

Among the conditions in return statement were identical ones, which is a simple typo. The solution is a removal of unnecessary repetitions.

Before:

return (opc_is_stringop_loop(opc) ||
        opc == OP_ins || opc == OP_outs || opc == OP_movs ||
        opc == OP_stos || opc == OP_lods || opc == OP_cmps ||
        opc == OP_cmps || opc == OP_scas || opc == OP_scas);

After:

return (opc_is_stringop_loop(opc) ||
        opc == OP_ins || opc == OP_outs || opc == OP_movs ||
        opc == OP_stos || opc == OP_lods || opc == OP_cmps ||
        opc == OP_scas);

Fixes #2190

Copy link
Contributor

@derekbruening derekbruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style nit: see https://dynamorio.org/page_code_reviews.html#sec_commit_messages about the title which should have a colon after the issue number. I will edit it.

@derekbruening derekbruening changed the title i#2190 fixed a typo of identical conditions i#2190: Fix a typo of identical conditions Mar 12, 2025
@derekbruening derekbruening merged commit b9eae5e into DynamoRIO:master Mar 12, 2025
7 checks passed
@Artem-OSSRevival
Copy link
Contributor Author

style nit: see https://dynamorio.org/page_code_reviews.html#sec_commit_messages about the title which should have a colon after the issue number. I will edit it.

Thanks for the correction, again :) maybe the next time it will turn out even better :)

@Artem-OSSRevival Artem-OSSRevival deleted the t5534 branch March 31, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

identical condition
2 participants