Skip to content

Conversation

@vikas-kumar-git
Copy link
Contributor

@vikas-kumar-git vikas-kumar-git commented Mar 24, 2025

Fixes Issue

My PR closes #747

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

The issue of unwanted scrollbars appearing due to image overflow was fixed by applying Tailwind CSS classes ( max-h-[90vh] )to the tag and removed 'h-auto' class because it was not required. The change will cause image to resize according to the available space and will not overflow due to different aspect ratio of screen.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

Before
image
After
image

…wind CSS to img tag

The issue of unwanted scrollbars appearing due to image overflow was fixed by applying Tailwind CSS classes ( max-h-[90vh] )to the <img> tag and removed 'h-auto' class because it was not required.
The change will cause image to resize according to the available space and will not overflow due to different aspect ratio of screen.
fix(home.js): resolve image overflow causing scrollbar by adding Tailwind css class
@vercel
Copy link

vercel bot commented Mar 24, 2025

@vikas-kumar-git is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Dun-sin
Copy link
Owner

Dun-sin commented Mar 24, 2025

@vikas-kumar-git can you remove this from draft?

@Dun-sin
Copy link
Owner

Dun-sin commented Mar 24, 2025

and next time even if you want to work on it, i will not approve your pull request without you being assigned to the original issue

@vercel
Copy link

vercel bot commented Mar 24, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper-b2p2 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Mar 24, 2025 10:13am

@vikas-kumar-git
Copy link
Contributor Author

I have removed the draft and made it ready for review . Thanks

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star, sharing the project with your friends, and joining the community discord server if you haven't for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit 81b94b5 into Dun-sin:main Apr 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Landing page scroll error in 15 inch laptop

2 participants