-
Notifications
You must be signed in to change notification settings - Fork 471
fix : resolved the image overflow through adding tailwind css class #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
β¦wind CSS to img tag The issue of unwanted scrollbars appearing due to image overflow was fixed by applying Tailwind CSS classes ( max-h-[90vh] )to the <img> tag and removed 'h-auto' class because it was not required. The change will cause image to resize according to the available space and will not overflow due to different aspect ratio of screen.
fix(home.js): resolve image overflow causing scrollbar by adding Tailwind css class
|
@vikas-kumar-git is attempting to deploy a commit to the dunsin's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@vikas-kumar-git can you remove this from draft? |
|
and next time even if you want to work on it, i will not approve your pull request without you being assigned to the original issue |
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
|
I have removed the draft and made it ready for review . Thanks |
Dun-sin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.
Consider giving this project a star, sharing the project with your friends, and joining the community discord server if you haven't for more resources and opportunities to connect with others. ππ½hereππ½
Fixes Issue
My PR closes #747
π¨βπ» Changes proposed(What did you do ?)
The issue of unwanted scrollbars appearing due to image overflow was fixed by applying Tailwind CSS classes ( max-h-[90vh] )to the tag and removed 'h-auto' class because it was not required. The change will cause image to resize according to the available space and will not overflow due to different aspect ratio of screen.
βοΈ Check List (Check all the applicable boxes)
Note to reviewers
π· Screenshots
Before


After