refactor: signup/login request 형식 검증 추가 (#30)

* build: gradle version update * refactor: 로그인/회원가입 요청 형식 검증 추가
Drugbox-graduate-project · Aug 30, 2024 · 72ebe69 · 72ebe69
1 parent 7354bc8
commit 72ebe69
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/build.gradle b/build.gradle
@@ -2,7 +2,7 @@ plugins {
     id 'java'
     id 'org.springframework.boot' version '2.7.5'
     id 'io.spring.dependency-management' version '1.1.4'
-    id "com.gorylenko.gradle-git-properties" version "2.2.4" // actutator-git
+    id "com.gorylenko.gradle-git-properties" version "2.4.1"
 }
 
 group = 'com'
@@ -20,6 +20,10 @@ configurations {
 
 repositories {
     mavenCentral()
+    maven {
+        url "https://plugins.gradle.org/m2/"
+    }
+    jcenter()
 }
 
 dependencies {
@@ -77,6 +81,8 @@ dependencies {
 
     // FCM
     implementation 'com.google.firebase:firebase-admin:9.1.1'
+
+    implementation 'org.ajoberstar.grgit:grgit-core:4.1.0'
 }
 
 tasks.named('test') {

diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties
@@ -1,6 +1,6 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip
 networkTimeout=10000
 validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME

diff --git a/src/main/java/com/drugbox/controller/AuthController.java b/src/main/java/com/drugbox/controller/AuthController.java
@@ -41,7 +41,7 @@ public ResponseEntity<TokenDto> googleRedirect(@RequestParam("code") String auth
     }
 
     @PostMapping("/signup/pw")
-    public ResponseEntity<IdResponse> signup(@RequestBody UserLoginRequest userLoginRequest) {
+    public ResponseEntity<IdResponse> signup(@RequestBody @Valid UserLoginRequest userLoginRequest) {
         Long userId = authService.signup(userLoginRequest);
         IdResponse response = IdResponse.builder()
                 .id(userId)
@@ -50,7 +50,7 @@ public ResponseEntity<IdResponse> signup(@RequestBody UserLoginRequest userLogin
     }
 
     @PostMapping("/login/pw")
-    public ResponseEntity<TokenDto> login(@RequestBody UserLoginRequest userLoginRequest) {
+    public ResponseEntity<TokenDto> login(@RequestBody @Valid UserLoginRequest userLoginRequest) {
         return ResponseEntity.ok(authService.login(userLoginRequest));
     }
 

diff --git a/src/main/java/com/drugbox/dto/request/UserLoginRequest.java b/src/main/java/com/drugbox/dto/request/UserLoginRequest.java
@@ -8,12 +8,16 @@
 import org.springframework.security.authentication.UsernamePasswordAuthenticationToken;
 import org.springframework.security.crypto.password.PasswordEncoder;
 
+import javax.validation.constraints.NotBlank;
+
 @Getter
 @AllArgsConstructor
 @NoArgsConstructor
 public class UserLoginRequest {
 
+    @NotBlank(message = "이메일은 공백일 수 없습니다.")
     private String email;
+    @NotBlank(message = "비밀번호는 공백일 수 없습니다.")
     private String password;
 
     public User toUser(PasswordEncoder passwordEncoder) {