disable tests which are not supported by AL-Go#2
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an AL-Go-compatible configuration file to disable a set of AL test methods that currently can’t run under AL-Go due to test runner isolation constraints.
Changes:
- Introduce
test/disabledtests.jsonlisting disabled test methods in codeunit99209(PW Integration Test). - Document the disable reason per test entry (same reason across all entries).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an AL-Go-compatible disabled test list so the CI pipeline can skip integration tests that require running the Business Central test runner with isolation disabled (which AL-Go currently doesn’t support).
Changes:
- Introduces
test/disabledtests.jsoncontaining a list of disabled test methods for codeunit99209 "PW Integration Test". - Captures the rationale for disabling each test in the JSON entries.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2
to
+62
| { | ||
| "bug": "These tests require running the test runner with isolation disabled, which AL-Go does not currently support.", | ||
| "codeunitId": 99209, | ||
| "codeunitName": "PW Integration Test", | ||
| "method": "RunForListSingleItem" | ||
| }, | ||
| { | ||
| "bug": "These tests require running the test runner with isolation disabled, which AL-Go does not currently support.", | ||
| "codeunitId": 99209, | ||
| "codeunitName": "PW Integration Test", | ||
| "method": "RunForListMultipleItems" | ||
| }, | ||
| { | ||
| "bug": "These tests require running the test runner with isolation disabled, which AL-Go does not currently support.", | ||
| "codeunitId": 99209, | ||
| "codeunitName": "PW Integration Test", | ||
| "method": "RunForListSplitsEvenly" | ||
| }, | ||
| { | ||
| "bug": "These tests require running the test runner with isolation disabled, which AL-Go does not currently support.", | ||
| "codeunitId": 99209, | ||
| "codeunitName": "PW Integration Test", | ||
| "method": "RunForListFewerItemsThanThreads" | ||
| }, | ||
| { | ||
| "bug": "These tests require running the test runner with isolation disabled, which AL-Go does not currently support.", | ||
| "codeunitId": 99209, | ||
| "codeunitName": "PW Integration Test", | ||
| "method": "RunForListWaitReturnsTrue" | ||
| }, | ||
| { | ||
| "bug": "These tests require running the test runner with isolation disabled, which AL-Go does not currently support.", | ||
| "codeunitId": 99209, | ||
| "codeunitName": "PW Integration Test", | ||
| "method": "RunForListCountersCorrectAfterCompletion" | ||
| }, | ||
| { | ||
| "bug": "These tests require running the test runner with isolation disabled, which AL-Go does not currently support.", | ||
| "codeunitId": 99209, | ||
| "codeunitName": "PW Integration Test", | ||
| "method": "RunForChunksWithPayloads" | ||
| }, | ||
| { | ||
| "bug": "These tests require running the test runner with isolation disabled, which AL-Go does not currently support.", | ||
| "codeunitId": 99209, | ||
| "codeunitName": "PW Integration Test", | ||
| "method": "RunForChunksIgnoresThreadCount" | ||
| }, | ||
| { | ||
| "bug": "These tests require running the test runner with isolation disabled, which AL-Go does not currently support.", | ||
| "codeunitId": 99209, | ||
| "codeunitName": "PW Integration Test", | ||
| "method": "RunForRecordsSplitsAcrossThreads" | ||
| }, | ||
| { | ||
| "bug": "These tests require running the test runner with isolation disabled, which AL-Go does not currently support.", | ||
| "codeunitId": 99209, | ||
| "codeunitName": "PW Integration Test", | ||
| "method": "RunForRecordsFewerRecordsThanThreads" | ||
| }, | ||
| { |
Comment on lines
+63
to
+81
| "bug": "Need to set isolation disabled test runner. Currently not supported by AL-Go.", | ||
| "codeunitId": 99209, | ||
| "codeunitName": "PW Integration Test", | ||
| "method": "WorkerErrorCaptured" | ||
| }, | ||
| { | ||
| "bug": "Need to set isolation disabled test runner. Currently not supported by AL-Go.", | ||
| "codeunitId": 99209, | ||
| "codeunitName": "PW Integration Test", | ||
| "method": "PartialFailureMixedResults" | ||
| }, | ||
| { | ||
| "bug": "Need to set isolation disabled test runner. Currently not supported by AL-Go.", | ||
| "codeunitId": 99209, | ||
| "codeunitName": "PW Integration Test", | ||
| "method": "AllChunksFail" | ||
| }, | ||
| { | ||
| "bug": "Need to set isolation disabled test runner. Currently not supported by AL-Go.", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.