Move MSVC runners to CI rules using root CMakeLists.txt #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrTimothyAldenDavis
merged commit c90fdaf
into
DrTimothyAldenDavis:dev2
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a matrix for MSVC to the CI rules using the root CMakeLists.txt to build with and without OpenMP. That will have the ctests run for these two configurations.
No ctests (nor demos) are run in the CI rules that build all libraries separately with MSVC. So, we won't loose anything if we removed those runners from that set of CI rules. Do that to save some CI minutes (even if they might be free of cost).
The other runners (that build the libraries separately) run
make demos. There is (currently) no equivalent to that with the root CMakeLists.txt. So, keep those other runners to not loose any coverage.