ParU: First pass for CMake build rules #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library doesn't contain any C sources. Setting a C standard isn't needed.
|
Ah, yes, umf_internal.h again. For now, the umf_internal.h and amd_internal.h files can be copied into the ParU/Include folder. I will work on a more robust solution. |
DrTimothyAldenDavis
merged commit 9be1bb4
into
DrTimothyAldenDavis:dev2
15 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is building now in most of the configurations of the CI.
It's only still failing for MSVC with OpenMP. Maybe, we need some additional flags for that? But it's getting late here. And the current state might be enough to share.
This library also seems to include a header that isn't installed:
umf_internal.hwhich in turn includesamd_internal.h. Should these be copied again? (I don't really like that workaround...)