ParU: Don't include headers in extern "C"
block.
#451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building ParU with a CHOLMOD library that was built with CUDA currently fails with this error:
(e.g.: https://github.com/DrTimothyAldenDavis/SuiteSparse/actions/runs/6578211130/job/17871436856#step:8:7567 )
The proposed change should be avoiding that error by not including headers inside an
extern "C"
block. (It would be easier to check whether this actually works if #450 was merged.)Afaict, there is no difference in
typedef enum [...]
between C and C++. So, remove theextern "C"
block entirely for simplicity.