Set preprocessor macro SUITESPARSE_CUDA on a per-target level #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this PR be merged? That would allow to get #415 in a more or less ready state to be considered for merging... |
|
Merging it now. Thanks! |
DrTimothyAldenDavis
merged commit 0f6dc71
into
DrTimothyAldenDavis:dev2
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting the preprocessor definition
SUITESPARSE_CUDAglobally, set it on a per-target level.This avoids some issues when trying to build everything with a root CMakeLists.txt (in particular GraphBLAS which currently needs to deviate from the global setting).