Skip to content

Commit

Permalink
Revert: mongoose: no declspec(dllimport) for static data
Browse files Browse the repository at this point in the history
This (partly) reverts 7c5caf6

Static members of a class can be accessed without instantiating the
class:
https://en.cppreference.com/w/cpp/language/static
That is conceptionally different from static data. They require
`dllexport`/`dllimport` attributes to be correctly exported from dlls
using MSVC.
  • Loading branch information
mmuetzel committed Jun 13, 2024
1 parent f39f756 commit 711a7d1
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions Mongoose/Include/Mongoose_Logger.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,10 @@ typedef enum TimingType
class Logger
{
private:
/* MONGOOSE_API */ static int debugLevel;
/* MONGOOSE_API */ static bool timingOn;
/* MONGOOSE_API */ static double clocks[6];
/* MONGOOSE_API */ static float times[6];
MONGOOSE_API static int debugLevel;
MONGOOSE_API static bool timingOn;
MONGOOSE_API static double clocks[6];
MONGOOSE_API static float times[6];

public:
static inline void tic(TimingType timingType);
Expand Down

0 comments on commit 711a7d1

Please sign in to comment.