Skip to content

fix d_mean calculation in PLPR, update tests#392

Draft
JulianDiefenbacher wants to merge 1 commit intomainfrom
jd-fix-plpr-bug
Draft

fix d_mean calculation in PLPR, update tests#392
JulianDiefenbacher wants to merge 1 commit intomainfrom
jd-fix-plpr-bug

Conversation

@JulianDiefenbacher
Copy link
Copy Markdown
Member

Description

Fix _set_d_mean() computation in DoubleMLPLPR. Update corresponding tests.

Reference to Issues or PRs

Comments

PR Checklist

Please fill out this PR checklist (see our contributing guidelines for details).

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • References to related issues or PRs are added.
  • The code passes all (unit) tests.
  • Enhancements or new feature are equipped with unit tests.
  • The changes adhere to the PEP8 standards.

Copy link
Copy Markdown
Member

@SvenKlaassen SvenKlaassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just waiting for the workflows before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Issue in computing d_mean when rows are dropped (DoubleMLPanelData, DoubleMLPLPR, approach "cre_general")

2 participants