-
-
Notifications
You must be signed in to change notification settings - Fork 244
Vibe coded PR: Reload page on 401 to recover from forward-auth session expiry #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sherrmann
wants to merge
1
commit into
Donkie:master
Choose a base branch
from
sherrmann:feat/reload-on-401-forwardauth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import { axiosInstance } from "@refinedev/simple-rest"; | ||
|
|
||
| const RELOAD_FLAG_KEY = "spoolmanAuthReloadedAt"; | ||
| const RELOAD_COOLDOWN_MS = 30_000; | ||
|
|
||
| /** | ||
| * Reloads the page on 401 so a forward-auth proxy can redirect through its | ||
| * login portal and back. Cooldown bounds reload loops if recovery fails. The | ||
| * PWA service worker's NavigationRoute would otherwise serve the precached | ||
| * index.html and prevent the reload from reaching the proxy, so unregister it. | ||
| */ | ||
| async function reloadOnAuthFailure(): Promise<void> { | ||
| let last = 0; | ||
| try { | ||
| last = Number(localStorage.getItem(RELOAD_FLAG_KEY) || "0"); | ||
| } catch { | ||
| /* storage unavailable */ | ||
| } | ||
| if (Date.now() - last < RELOAD_COOLDOWN_MS) return; | ||
| try { | ||
| localStorage.setItem(RELOAD_FLAG_KEY, String(Date.now())); | ||
| } catch { | ||
| /* storage unavailable */ | ||
| } | ||
| if ("serviceWorker" in navigator) { | ||
| try { | ||
| const registrations = await navigator.serviceWorker.getRegistrations(); | ||
| await Promise.all(registrations.map((r) => r.unregister())); | ||
|
sherrmann marked this conversation as resolved.
|
||
| } catch { | ||
| /* fall through to reload anyway */ | ||
| } | ||
| } | ||
| window.location.reload(); | ||
| } | ||
|
|
||
| axiosInstance.interceptors.response.use( | ||
| (response) => response, | ||
| (error) => { | ||
| if (error?.response?.status === 401) { | ||
| // Auto-reload only on idempotent requests so unsaved form data on | ||
| // POST/PUT/PATCH/DELETE is preserved — mutation 401s surface through | ||
| // the Refine notification provider instead. | ||
| const method = String(error.config?.method ?? "get").toLowerCase(); | ||
| if (method === "get" || method === "head") void reloadOnAuthFailure(); | ||
| } | ||
|
sherrmann marked this conversation as resolved.
|
||
| return Promise.reject(error); | ||
| }, | ||
| ); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.