-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the crate no_std
compatible?
#89
Draft
JSorngard
wants to merge
11
commits into
master
Choose a base branch
from
no_std
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
==========================================
- Coverage 94.78% 94.77% -0.02%
==========================================
Files 9 10 +1
Lines 1689 1742 +53
==========================================
+ Hits 1601 1651 +50
- Misses 88 91 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I may have figured out a way to make the crate
no_std
compatible!I added the
std
feature (disabled by default currently) that can be activated to enable the currentBacktrace
functionality of the error types, since that needs the standard library.Potential trade-offs:
rayon
depends on the standard library, so if that feature is enabled it doesn't really matter that we areno_std
.libm
crate to compute square roots and trigonometric functions if thestd
feature is disabled. When thestd
feature is enabled we depend onlibm
even if we never use it.Error
trait in core.Roadblocks
Currently the compiler complains when I run
cargo check
that there is no allocator, but it works when I runcargo test
. I do not know how to resolve this yet. I am also confused about why it doesn't work right now, as I have already used the functionality I use here to make myconst-primes
crateno_std
, and that worked without this issue.