-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that all quadrature rules store their nodes in sorted order. #112
base: master
Are you sure you want to change the base?
Conversation
This reduced accuracy in one of the integration tests by approx 7e-16
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 94.94% 95.06% +0.11%
==========================================
Files 10 10
Lines 1939 1986 +47
==========================================
+ Hits 1841 1888 +47
Misses 98 98 ☔ View full report in Codecov by Sentry. |
Sorting reduced the accuracy of the integration in the test of GaussHermite::new(5).unwrap().integrate(|_| 1.0) I reduced the required threshold of the test to 1e-14 from 1e-15, but I think it is worth flagging in the discussion. |
@DomiDre what do you think of this? |
This PR adresses #102.