Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all quadrature rules store their nodes in sorted order. #112

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

JSorngard
Copy link
Collaborator

This PR adresses #102.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.06%. Comparing base (9566364) to head (350e362).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   94.94%   95.06%   +0.11%     
==========================================
  Files          10       10              
  Lines        1939     1986      +47     
==========================================
+ Hits         1841     1888      +47     
  Misses         98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JSorngard JSorngard requested a review from DomiDre January 6, 2025 09:44
@JSorngard
Copy link
Collaborator Author

Sorting reduced the accuracy of the integration in the test of

GaussHermite::new(5).unwrap().integrate(|_| 1.0)

I reduced the required threshold of the test to 1e-14 from 1e-15, but I think it is worth flagging in the discussion.

@JSorngard
Copy link
Collaborator Author

@DomiDre what do you think of this?

@JSorngard JSorngard changed the title Ensure that all quadrature rules store their weights in sorted order. Ensure that all quadrature rules store their nodes in sorted order. Feb 7, 2025
@JSorngard JSorngard added the enhancement New feature or request label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some rules generate their nodes in reverse sorted or unsorted order
1 participant