feat: detect Kiro auth expiration + add kronn auth kiro command#42
Open
Elenui wants to merge 4 commits into
Hidden character warning
The head ref may contain hidden characters: "kronn/lorsque-kronn-est-lanc\u00e9-depuis-par-exemple-1-jours-et-qu-on"
Open
feat: detect Kiro auth expiration + add kronn auth kiro command#42Elenui wants to merge 4 commits into
Elenui wants to merge 4 commits into
Conversation
Collaborator
Elenui
commented
Mar 25, 2026
Elenui
commented
- Better error message when Kiro session expires (no output case)
- Add AWS Builder ID / SSO patterns in detect_agent_error_hint
- New CLI command: kronn auth kiro (re-auth without restart)
- Frontend: show specific hint for Kiro auth errors
Elenui
force-pushed
the
kronn/lorsque-kronn-est-lancé-depuis-par-exemple-1-jours-et-qu-on
branch
2 times, most recently
from
9b0b5dd to
7a8726a
Compare
Elenui
force-pushed
the
kronn/lorsque-kronn-est-lancé-depuis-par-exemple-1-jours-et-qu-on
branch
2 times, most recently
from
ad31fbc to
4c582f3
Compare
DocRoms
reviewed
Mar 25, 2026
| if let Some(hint) = error_hint { | ||
| full_response.push_str(&format!("\n\n{}", hint)); | ||
| // Replace raw agent output with clean error message | ||
| full_response = hint; |
Owner
There was a problem hiding this comment.
Écrasement de la sortie agent : full_response = hint remplace entièrement la sortie brute de l'agent par le hint. ^^
Problèmes potentiels :
- Debug impossible : l'utilisateur perd le stderr/stdout original, aucun moyen de comprendre un faux positif
- Faux positifs : les patterns sont larges ("login required", "opening browser", "session expired") et detect_agent_error_hint s'applique à tous les agents, pas seulement Kiro. Si Claude Code ou Codex renvoie un message contenant "session expired" dans un contexte légitime, il est écrasé.
- Pas de trace — le contenu original n'est ni loggé ni stocké
On pourrait garder le hint visible en premier, mais conserver la sortie originale repliable 🤔 ? :
full_response = format!(
"{}\n\n<details><summary>Sortie agent</summary>\n\n{}\n</details>"
hint, full_response
);| let all_output = format!("{}\n{}", full_response, stderr_text); | ||
| if let Some(hint) = detect_agent_error_hint(&all_output) { | ||
| full_response.push_str(&format!("\n\n{}", hint)); | ||
| full_response = hint; |
Owner
There was a problem hiding this comment.
full_response = hint écrase la sortie originale. À traiter de la même façon que plus haut ^^ ⏫
| || lower.contains("sso session") | ||
| || lower.contains("refresh token") | ||
| || lower.contains("device flow") | ||
| || lower.contains("login required") |
Owner
There was a problem hiding this comment.
Les patterns de détection Kiro sont très larges et risquent des faux positifs sur d'autres agents :
- "opening browser" — un agent qui parle de devtools
- "login required" — un agent qui documente une API
- "device flow" — un agent qui explique un flow OAuth
On pourrait surement conditionner sur le type d'agent , ou passer agent_type à detect_agent_error_hint 😄
| print(f"✅ Backup → {BACKUP}") | ||
|
|
||
| conn = sqlite3.connect(str(DB)) | ||
| cur = conn.execute("DELETE FROM auth_kv WHERE key = 'kirocli:odic:token'") |
Owner
There was a problem hiding this comment.
Typo non ? kirocli:odic:token → kirocli:oidc:token(OIDC = OpenID Connect).
| "node": ">=18" | ||
| } | ||
| }, | ||
| "node_modules/@diffusionstudio/vits-web": { |
Owner
There was a problem hiding this comment.
🤔 Le projet utilise pnpm, et non pas npm ^^ on ne devrait pas avoir autant de changements sur le lock ;)
Elenui
force-pushed
the
kronn/lorsque-kronn-est-lancé-depuis-par-exemple-1-jours-et-qu-on
branch
from
f4083cf to
fba9874
Compare
- Better error message when Kiro session expires (no output case) - Add AWS Builder ID / SSO patterns in detect_agent_error_hint - New CLI command: kronn auth kiro (re-auth without restart) - Frontend: show specific hint for Kiro auth errors Signed-off-by: Alexis TARUSSIO <alexis.tarussio@gmail.com>
Signed-off-by: Alexis TARUSSIO <alexis.tarussio@gmail.com>
Elenui
force-pushed
the
kronn/lorsque-kronn-est-lancé-depuis-par-exemple-1-jours-et-qu-on
branch
from
fba9874 to
3f810f2
Compare
Signed-off-by: Alexis TARUSSIO <alexis.tarussio@gmail.com>
Elenui
force-pushed
the
kronn/lorsque-kronn-est-lancé-depuis-par-exemple-1-jours-et-qu-on
branch
from
3f810f2 to
0271d99
Compare
Elenui
added
ci-test
Elenui
added
ci-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.