Skip to content

Commit

Permalink
Remove explicit symbol sizes in sym_common.txt
Browse files Browse the repository at this point in the history
  • Loading branch information
GriffinRichards committed Sep 25, 2024
1 parent 473e062 commit 80a37c1
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 41 deletions.
1 change: 1 addition & 0 deletions common_syms/ereader_screen.txt
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
gUnknownSpace
gEReaderData
3 changes: 3 additions & 0 deletions src/ereader_screen.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ struct EReaderData

static void Task_EReader(u8);

// This belongs in COMMON somewhere between party_menu and ereader_screen, but it's unused so it's unclear where.
UNUSED u8 gUnknownSpace[64];

struct EReaderData gEReaderData;

extern const u8 gMultiBootProgram_EReader_Start[];
Expand Down
48 changes: 7 additions & 41 deletions sym_common.txt
Original file line number Diff line number Diff line change
@@ -1,37 +1,10 @@
.space 0x8
.include "main.o"
@ ../src/bg.o
.align 2
gWindowTileAutoAllocEnabled:
.space 4
@ ../src/window.o
.align 4
gTransparentTileNumber:
.space 1
.align 4
gWindowBgTilemapBuffers:
.space 16
@ ../src/text.o
.align 4
gFonts:
.space 4
.align 2
gDisableTextPrinters:
.space 1
.align 4
gCurGlyph:
.space 132
.align 2
gTextFlags:
.space 4
@ ../src/sprite.o
.align 2
gOamMatrixAllocBitmap:
.space 4
.align 2
gReservedSpritePaletteCount:
.space 1
.include "main.o"
.include "bg.o"
.align 4
.include "window.o"
.include "text.o"
.include "sprite.o"
.include "link.o"
.include "AgbRfu_LinkManager.o"
.include "link_rfu_2.o"
Expand All @@ -53,9 +26,7 @@ gReservedSpritePaletteCount:
.include "tv.o"
.include "mauville_old_man.o"
.include "image_processing_effects.o"

.space 0x4

.align 4
.include "contest_painting.o"
.include "field_specials.o"
.include "evolution_scene.o"
Expand All @@ -66,14 +37,9 @@ gReservedSpritePaletteCount:
.include "battle_anim_throw.o"
.include "battle_factory_screen.o"
.include "apprentice.o"

.space 0x8

.align 4
.include "list_menu.o"
.include "party_menu.o"

.space 0x44

.include "ereader_screen.o"
.include "m4a.o"
.include "agb_flash.o"
Expand Down

0 comments on commit 80a37c1

Please sign in to comment.