Cleanup various parts of the library #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User shouldn't be calling this anyway
…treamer` Moving the Chacha20 options to the Streamer class is probably a good move, since it's unlikely that anyone would want 2 separate encryption methods for the 2 streams
commit: |
The functionality is now built in to the library
Untested, but I don't see why it shouldn't work
Due to some unknown causes, the event ends up firing before the handler is attached
|
My bot doesn't die! As always, please test major changes like this, I might have messed up somewhere else |
|
I will rewrite some parts of the library to reduce comments like this
I apologize for the inconvenience ;-; |
|
It's okay, take your time, so far it hasn't affected anything yet |
|
Will merge after a few hours if no one found anything bad |
|
Seems fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes ahead :)
streamLivestreamVideoand the accompanying problematicstreamOptionspropertyAudioStreamandVideoStream. Users don't need to touch this everforceChacha20EncryptionandrtcpSenderReportEnabledoptions to theStreamerclassprepareStreamandplayStreamas top level exportsStuff to do:
^5.0.0)