Feature: Let users downloads Icons from Professional mode, that are only available to watchers of that deviation #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PickCommand and OpenImageCommand in the ProSearchResultViewModel have been refactored to take a DArtImageList object directly, instead of an object. This means we can handle the "MustWatch" property in the commands, allowing us to manage scenarios where the image needs to be watched to be downloaded. Additionally, a new property 'PremiumFolderData' has been added to 'DArtBrowseResult.cs', allowing tracking of folders with premium accessibility. Corresponding adjustments were made on the UI side in ProSearchResult.xaml. The 'DArtImageList' constructor is also updated to accept a new parameter - 'mustWatch'.
|
There was a problem hiding this comment.
Pull Request Overview
This PR enables users in Professional mode to download icons hidden behind a watcher wall by adjusting the API models and updating view logic.
- Introduces a new PremiumFolderData model to capture premium folder properties.
- Refines command parameter types and logic in ProSearchResultViewModel to handle the "must watch" condition.
- Adds a MustWatch flag to DArtImageList for indicating icons that require watching.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| FoliCon/Models/Api/DArtBrowseResult.cs | Adds PremiumFolderData with properties to support premium content access. |
| FoliCon/ViewModels/ProSearchResultViewModel.cs | Refactors command parameter types and image selection logic to incorporate must-watch functionality. |
| FoliCon/Models/Data/DArtImageList.cs | Updates constructor and adds MustWatch property to support the new logic. |
| public bool HasAccess { get; set; } | ||
|
|
||
| [JsonProperty("gallery_id")] | ||
| public string GallaryId { get; set; } |
There was a problem hiding this comment.
The property name 'GallaryId' appears to be misspelled. Consider renaming it to 'GalleryId' for clarity and consistency.
Suggested change
| public string GallaryId { get; set; } | |
| public string GalleryId { get; set; } |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deviant Art creators can restrict download based on either paying subscribing and watching of their art.
Currently FoliCon filters all these as not downloadable and does not show them.
However we can 'watch' their deviation to download. so FoliCon will now show images hidden behind "watcher wall" and watch them to download if user selects it.