Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug #454 #456

Open
wants to merge 2 commits into
base: 1.20.1-multiplatform
Choose a base branch
from

Conversation

ForgotTheColon
Copy link

Chunk must be loaded, otherwise you get teleported at bedrock level. I have very little modding experience, and documentation for such a popular game feels awful, so even this simple fix took me a while. If you have any issue with how this is written, let me know.

@Singul0
Copy link

Singul0 commented Jan 5, 2025

thank you for your work :)

@Slime3673
Copy link

so how do you fix it on forge

@ForgotTheColon
Copy link
Author

This fix isn't specific to forge/fabric, there's a forge, fabric, and common directory and this modifies files in the common one

@ForgotTheColon
Copy link
Author

I provided a compiled fabric and forge jar on my fork under the releases if anyone would like to try it out, since I saw in the discord someone ran the build themselves on my fork.

@Slime3673
Copy link

so where would i click to find the file and where would i put it in the modpack folder

@ForgotTheColon
Copy link
Author

Man, you really made an github account just to comment on this, huh. Well I understand I've had friends on the consumer side get confused by github, but it'd be under my fork and on the releases page;
https://github.com/ForgotTheColon/DimDoors/releases

@Slime3673
Copy link

should i put it in the mods folder

@ForgotTheColon
Copy link
Author

yes, make sure you download the dependencies Architectury API and Cloth Config API, and make sure you use the right version, -forge or -fabric.

I'd like to not clutter this PR's comments anymore because it's really meant for critique on the code and not telling people how to use github/install mods - no offense.

@Slime3673
Copy link

just one more question should i get rid of old dim doors or should i just have both in there

@ForgotTheColon
Copy link
Author

Just get rid of the version you had before, this version is basically 5.4.3 with one small change to fix the bug, hence 5.4.3-1.

(There's a code change that should be in the fork but since I didn't make a branch for this PR I didn't actually include that in my build, but that's just babble you don't have to care about).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants