Repairing changes to Limbo options #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repairing changes
Repairing changes
|
May i ask when u upload the new Version for tests? :) |
|
For the record, you can just use ResourceLocation.tryParse(DimensionalDoors.getConfig().getLimboConfig().escapeTargetWorldinstead of new ResourceLocation(DimensionalDoors.getConfig().getLimboConfig().escapeTargetWorld.split(":")[0], DimensionalDoors.getConfig().getLimboConfig().escapeTargetWorld.split(":")[1]) |
|
Replying to a deleted comment, but yes this should still work - the only two files I've changed in this PR haven't changed since before this PR was made. I'm also bumping this PR since it's remained stale for just over a month now. |
|
I might fork and publish a temporary version with this fix to be archived once this gets merged and published |
|
Removed the escapeTargetWorldYSpawn config option since MysticPasta's teleport commit removed the option's utility. Hopefully spawning back in the chosen dimension should work better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes (presumably untested changes) were made to the new Limbo-related config options I added in my last PR, which caused these options to no longer work, and for the options to reset on game launch like before. I have reverted these changes, and I've verified they work via testing. This should also fix issue #435.
Apologies if I sound rude, that is not my intention; I only want things to work as intended. Thanks!