Bump kotlin from 2.2.21 to 2.3.0

app/build.gradle.kts

@@ -256,4 +256,8 @@ kotlin {
             }
         }
     }
+}
+
+ktorfit {
+    compilerPluginVersion.set("2.3.3")
 }

gradle/libs.versions.toml

@@ -7,7 +7,7 @@ lifecycleViewmodelComposeVersion = "2.9.6"
 minSdk = "23"
 java = "21"
 agp = "8.13.2"
-kotlin = "2.2.21"
+kotlin = "2.3.0"
 core-ktx = "1.17.0"
 junit = "4.13.2"
 androidx-test-ext-junit = "1.3.0"

shared/build.gradle.kts

@@ -128,6 +128,10 @@ room {
     schemaDirectory("$projectDir/schemas")
 }
 
+ktorfit {
+    compilerPluginVersion.set("2.3.3")
+}
+
 ktlint {
     version.set(libs.versions.ktlint)
     filter {

shared/src/commonMain/kotlin/dev/dimension/flare/data/database/cache/mapper/Bluesky.kt

@@ -218,9 +218,8 @@ internal fun List<ListNotificationsNotification>.toDb(
                             when (reason) {
                                 ListNotificationsNotificationReason.Repost -> it.decodeAs<Repost>().subject
                                 ListNotificationsNotificationReason.Like -> it.decodeAs<Like>().subject
-                                else -> null
                             }
-                        }?.uri
+                        }.uri
                         .let {
                             references[it]
                         }
@@ -233,7 +232,6 @@ internal fun List<ListNotificationsNotification>.toDb(
                     when (reason) {
                         ListNotificationsNotificationReason.Repost -> "_repost"
                         ListNotificationsNotificationReason.Like -> "_like"
-                        else -> ""
                     }
                 val data =
                     DbStatusWithUser(

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/FansPagingSource.kt

@@ -34,7 +34,7 @@ internal class FansPagingSource(
                     it.follower?.render(accountKey = accountKey)
                 },
             prevKey = null,
-            nextKey = response?.lastOrNull()?.id,
+            nextKey = response.lastOrNull()?.id,
         )
     }
 }

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/FavouriteTimelineRemoteMediator.kt

@@ -50,9 +50,7 @@ internal class FavouriteTimelineRemoteMediator(
                         ),
                     )
                 }
-            } ?: return Result(
-                endOfPaginationReached = true,
-            )
+            }
 
         val notes = response.map { it.note }
         val data =

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/FollowingPagingSource.kt

@@ -35,7 +35,7 @@ internal class FollowingPagingSource(
                     it.followee?.render(accountKey = accountKey)
                 },
             prevKey = null,
-            nextKey = response?.lastOrNull()?.id,
+            nextKey = response.lastOrNull()?.id,
         )
     }
 }

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/HomeTimelineRemoteMediator.kt

@@ -46,9 +46,7 @@ internal class HomeTimelineRemoteMediator(
                         ),
                     )
                 }
-            } ?: return Result(
-                endOfPaginationReached = true,
-            )
+            }
 
         return Result(
             endOfPaginationReached = response.isEmpty(),

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/HybridTimelineRemoteMediator.kt

@@ -41,9 +41,7 @@ internal class HybridTimelineRemoteMediator(
                         ),
                     )
                 }
-            } ?: return Result(
-                endOfPaginationReached = true,
-            )
+            }
 
         return Result(
             endOfPaginationReached = response.isEmpty(),

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/ListTimelineRemoteMediator.kt

@@ -55,9 +55,7 @@ internal class ListTimelineRemoteMediator(
                             ),
                         )
                 }
-            } ?: return Result(
-                endOfPaginationReached = true,
-            )
+            }
 
         return Result(
             endOfPaginationReached = response.isEmpty(),

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/LocalTimelineRemoteMediator.kt

@@ -43,9 +43,7 @@ internal class LocalTimelineRemoteMediator(
                         ),
                     )
                 }
-            } ?: return Result(
-                endOfPaginationReached = true,
-            )
+            }
 
         return Result(
             endOfPaginationReached = response.isEmpty(),

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/MentionTimelineRemoteMediator.kt

@@ -43,9 +43,7 @@ internal class MentionTimelineRemoteMediator(
                         ),
                     )
                 }
-            } ?: return Result(
-                endOfPaginationReached = true,
-            )
+            }
 
         return Result(
             endOfPaginationReached = response.isEmpty(),

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/MisskeyDataSource.kt

@@ -209,9 +209,7 @@ internal class MisskeyDataSource(
                 val user =
                     service
                         .usersShow(UsersShowRequest(username = name, host = host))
-
-                        ?.toDbUser(accountKey.host)
-                        ?: throw Exception("User not found")
+                        .toDbUser(accountKey.host)
                 database.userDao().insert(user)
             },
             cacheSource = {
@@ -231,9 +229,7 @@ internal class MisskeyDataSource(
                 val user =
                     service
                         .usersShow(UsersShowRequest(userId = id))
-
-                        ?.toDbUser(accountKey.host)
-                        ?: throw Exception("User not found")
+                        .toDbUser(accountKey.host)
                 database.userDao().insert(user)
             },
             cacheSource = {
@@ -315,8 +311,7 @@ internal class MisskeyDataSource(
                 val emojis =
                     service
                         .emojis()
-
-                        ?.emojis
+                        .emojis
                         .orEmpty()
                         .toImmutableList()
                 database.emojiDao().insert(
@@ -921,7 +916,7 @@ internal class MisskeyDataSource(
                 )
             }.fold(
                 onSuccess = {
-                    emit(it?.isFavorited == true)
+                    emit(it.isFavorited == true)
                 },
                 onFailure = {
                     emit(false)
@@ -1053,19 +1048,17 @@ internal class MisskeyDataSource(
                     ),
                 )
         }.onSuccess { response ->
-            if (response?.id != null) {
-                MemoryPagingSource.updateWith<UiList>(
-                    key = listKey,
-                ) {
-                    it
-                        .plus(
-                            UiList(
-                                id = response.id,
-                                title = metaData.title,
-                                platformType = PlatformType.Mastodon,
-                            ),
-                        ).toImmutableList()
-                }
+            MemoryPagingSource.updateWith<UiList>(
+                key = listKey,
+            ) {
+                it
+                    .plus(
+                        UiList(
+                            id = response.id,
+                            title = metaData.title,
+                            platformType = PlatformType.Mastodon,
+                        ),
+                    ).toImmutableList()
             }
         }
     }
@@ -1122,7 +1115,7 @@ internal class MisskeyDataSource(
                         UsersListsShowRequest(
                             listId = listId,
                         ),
-                    )?.render() ?: throw Exception("List not found")
+                    ).render()
             },
         )
 
@@ -1207,8 +1200,8 @@ internal class MisskeyDataSource(
                         UsersShowRequest(
                             userId = userKey.id,
                         ),
-                    )?.toDbUser(accountKey.host)
-                    ?.render(accountKey)
+                    ).toDbUser(accountKey.host)
+                    .render(accountKey)
             MemoryPagingSource.updateWith(
                 key = listMemberKey(listId),
             ) {
@@ -1224,14 +1217,12 @@ internal class MisskeyDataSource(
                             listId = listId,
                         ),
                     )
-            if (list?.id != null) {
-                MemCacheable.updateWith<ImmutableList<UiList>>(
-                    key = userListsKey(userKey),
-                ) {
-                    it
-                        .plus(list.render())
-                        .toImmutableList()
-                }
+            MemCacheable.updateWith<ImmutableList<UiList>>(
+                key = userListsKey(userKey),
+            ) {
+                it
+                    .plus(list.render())
+                    .toImmutableList()
             }
         }
     }

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/NotificationRemoteMediator.kt

@@ -43,9 +43,7 @@ internal class NotificationRemoteMediator(
                         ),
                     )
                 }
-            } ?: return Result(
-                endOfPaginationReached = true,
-            )
+            }
 
         return Result(
             endOfPaginationReached = response.isEmpty(),

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/PublicTimelineRemoteMediator.kt

@@ -43,9 +43,7 @@ internal class PublicTimelineRemoteMediator(
                         ),
                     )
                 }
-            } ?: return Result(
-                endOfPaginationReached = true,
-            )
+            }
 
         return Result(
             endOfPaginationReached = response.isEmpty(),

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/SearchStatusRemoteMediator.kt

@@ -55,7 +55,7 @@ internal class SearchStatusRemoteMediator(
                         ),
                     )
                 }
-            } ?: emptyList()
+            }
 
         return Result(
             endOfPaginationReached = response.isEmpty(),

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/SearchUserPagingSource.kt

@@ -23,7 +23,7 @@ internal class SearchUserPagingSource(
                     limit = params.loadSize,
                     offset = params.key ?: 0,
                 ),
-            )?.let {
+            ).let {
                 return LoadResult.Page(
                     data = it.map { it.render(accountKey) },
                     prevKey = null,
@@ -34,8 +34,6 @@ internal class SearchUserPagingSource(
                             (params.key ?: 0) + params.loadSize
                         },
                 )
-            } ?: run {
-            return LoadResult.Error(Exception("No data"))
-        }
+            }
     }
 }

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/TrendHashtagPagingSource.kt

@@ -13,16 +13,15 @@ internal class TrendHashtagPagingSource(
     override suspend fun doLoad(params: LoadParams<Int>): LoadResult<Int, UiHashtag> {
         service
             .hashtagsTrend()
-
-            ?.map {
+            .map {
                 UiHashtag(
                     hashtag = it.tag,
                     description = null,
                     searchContent = "#${it.tag}",
                 )
             }.let {
                 return LoadResult.Page(
-                    data = it ?: emptyList(),
+                    data = it,
                     prevKey = null,
                     nextKey = null,
                 )

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/TrendsUserPagingSource.kt

@@ -17,12 +17,11 @@ internal class TrendsUserPagingSource(
     override suspend fun doLoad(params: LoadParams<Int>): LoadResult<Int, UiUserV2> {
         service
             .pinnedUsers(PinnedUsersRequest(limit = params.loadSize))
-
-            ?.map {
+            .map {
                 it.render(accountKey)
             }.let {
                 return LoadResult.Page(
-                    data = it ?: emptyList(),
+                    data = it,
                     prevKey = null,
                     nextKey = null,
                 )

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/vvo/VVODataSource.kt

@@ -229,7 +229,7 @@ internal class VVODataSource(
                     ?.user
             requireNotNull(user) { "user not found" }
             UiRelation(
-                following = user.following ?: false,
+                following = user.following,
                 isFans = user.followMe ?: false,
             )
         }.toUi()

shared/src/commonMain/kotlin/dev/dimension/flare/data/network/vvo/model/TimelineData.kt

@@ -45,7 +45,7 @@ internal data class VVOResponse<T>(
 )
 
 @OptIn(ExperimentalSerializationApi::class)
-private class VVOResponseSerializer<T>(
+internal class VVOResponseSerializer<T>(
     private val dataSer: KSerializer<T>,
 ) : KSerializer<VVOResponse<T>> {
     override val descriptor: SerialDescriptor =

shared/src/commonMain/kotlin/dev/dimension/flare/ui/model/mapper/Mastodon.kt

@@ -998,7 +998,7 @@ private fun parseName(status: Account): Element {
                 "<img src=\"${it.url}\" alt=\"${it.shortcode}\" />",
             )
     }
-    return parseHtml(content) as? Element ?: Element("body")
+    return parseHtml(content)
 }
 
 internal fun parseMastodonContent(

shared/src/commonMain/kotlin/dev/dimension/flare/ui/model/mapper/Misskey.kt

@@ -832,7 +832,7 @@ private fun parseName(
     if (name.isEmpty()) {
         return Element("body")
     }
-    return misskeyNameParser.parse(name).toHtml(accountKey, emojis, accountKey.host) as? Element ?: Element("body")
+    return misskeyNameParser.parse(name).toHtml(accountKey, emojis, accountKey.host)
 }
 
 private fun moe.tlaster.mfm.parser.tree.Node.toHtml(

shared/src/commonMain/kotlin/dev/dimension/flare/ui/model/mapper/XQT.kt

@@ -85,7 +85,7 @@ internal fun TopLevel.renderNotifications(
                 val users =
                     data?.template?.aggregateUserActionsV1?.fromUsers?.mapNotNull { ref ->
                         globalObjects
-                            ?.users
+                            .users
                             ?.get(ref.user?.id)
                             ?.let { userLegacy ->
                                 User(