Posts dependency check results as PR comments#270
Draft
Conversation
Replace the previous minimal dependency check workflow with an enhanced job that runs a maintained dependencies action and posts a summarized comment on the PR. It also manages a "blocked" label and fails the job when dependency issues are detected. This improves visibility of dependency problems directly in pull requests so maintainers can quickly see and act on blocked PRs without inspecting CI logs.
Removes the conditional guard on the post-check job so the processing and result posting step always runs. Ensures post-check handling executes regardless of prior step outcomes to avoid skipped reporting and improve reliability of dependency check notifications.
Ensure the workflow always executes the post-check processing step so that results are posted even when earlier steps fail. This prevents missing reporting or stale status when the dependency check job encounters errors.
The github-script action automatically provides core as a global variable, so we don't need to require it.
Adds the synchronize event to the pull request trigger so the dependency check runs when commits are pushed to an existing PR. Ensures dependency scans reflect the latest changes and reduces missed findings on updated pull requests.
Improve the PR dependency checker to provide reliable status and clearer notifications when dependency analysis is incomplete or delayed. Updates ensure the workflow reports a sensible outcome even if the check run API doesn't return annotations, uses the step outcome as a fallback, and avoids duplicate comments while keeping the PR labeled correctly. This reduces false negatives, clarifies results for contributors, and prevents stalled PRs due to missing check run data.
github-actions
bot
added
the
blocked
Dependency Checker |
DigiLive
force-pushed
the
enhance-dependency-checker
branch
from
99150c8 to
91f8dc0
Compare
Dependency Checker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Pull Request
Thank you for contributing to the project!
Please fill out the following information to help us review your pull request.
Feature Summary
This feature enhances the dependency checker workflow by posting the results of the dependency check as comments directly on the pull request. This provides immediate feedback to the user about any dependency issues. Additionally, a
blockedlabel will be added to the PR if the dependency check fails.Motivation and Context
This feature is needed to provide more immediate and visible feedback on dependency issues within a pull request. Previously, the dependency check ran silently, and users had to navigate to the Actions tab to view the results. Posting comments directly on the PR streamlines the process, making it easier for developers to identify and resolve dependency problems.
List of Changes
blockedlabel if it doesn't exist.Documentation Updates
No documentation updates are required.
Agreements
Please confirm the following by inserting an
xbetween the brackets:Depends on #247