fix: add plugin.yaml and pi-extension/package.json to VERSION_FILES#357
Open
nanaubusiness wants to merge 1 commit into
Open
fix: add plugin.yaml and pi-extension/package.json to VERSION_FILES#357nanaubusiness wants to merge 1 commit into
nanaubusiness wants to merge 1 commit into
Conversation
These two files declare a version field but were missing from the consistency check. This is the exact drift scenario caught by DietrichGebert#260/DietrichGebert#262. Also updates the file count comment from 7 to 9. Closes DietrichGebert#348
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two version-bearing files were missing from the
check-versions.jsconsistency check, creating the exact drift scenario that issues #260/#262 were filed for.Changes:
plugin.yaml(Hermes manifest) toVERSION_FILESpi-extension/package.jsontoVERSION_FILESCloses #348