Fix: handle unsupported locale in JokeSkill without NPE#414
Draft
mretallack wants to merge 1 commit intoDicioTeam:mainfrom
Draft
Fix: handle unsupported locale in JokeSkill without NPE#414mretallack wants to merge 1 commit intoDicioTeam:mainfrom
mretallack wants to merge 1 commit intoDicioTeam:mainfrom
Conversation
When the user changes language, there is a race condition where JokeSkill.generateOutput() can be called with a locale not in JOKE_SUPPORTED_LOCALES. This happened because the SkillRanker still holds the old JokeSkill instance while ctx.locale already reflects the new locale. The !! on resolveSupportedLocale() caused a NullPointerException. Replace with a safe return of JokeOutput.Failed. Fixes the crash reported in DicioTeam#412 where changing language on first install causes an NPE in JokeSkill. - Add JokeOutput.Failed variant with user-friendly message - Add regression test proving the NPE scenario
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user changes language, there is a race condition where JokeSkill.generateOutput() can be called with a locale not in JOKE_SUPPORTED_LOCALES. This happened because the SkillRanker still holds the old JokeSkill instance while ctx.locale already reflects the new locale.
The !! on resolveSupportedLocale() caused a NullPointerException. Replace with a safe return of JokeOutput.Failed.
Fixes the crash reported in #412 where changing language on first install causes an NPE in JokeSkill.