Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add support for rpop count parameter #1365

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Kripu77
Copy link
Contributor

@Kripu77 Kripu77 commented Dec 9, 2024

Description:

  • Add support for optional COUNT parameter with RPOP command similar to Redis.

@lucifercr07
Copy link
Contributor

@Kripu77 can you please fix lint and build issues.

@Kripu77
Copy link
Contributor Author

Kripu77 commented Dec 10, 2024

@Kripu77 can you please fix lint and build issues.

HI @lucifercr07, please let me know if you see any further issue.

@JyotinderSingh
Copy link
Collaborator

cc @lucifercr07

Copy link
Contributor

@lucifercr07 lucifercr07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kripu77 thanks for contributing, we can make changes to keep error msgs in parity with redis for these commands.
Else all looks good.

docs/src/content/docs/commands/RPOP.md Outdated Show resolved Hide resolved
docs/src/content/docs/commands/RPOP.md Outdated Show resolved Hide resolved
@Kripu77 Kripu77 requested a review from lucifercr07 January 19, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants