fix: use a dispatchqueue to synchronize setting and getting userConfig #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevCycle/Models/DVCConfig.swift
Outdated
| } | ||
|
|
||
| func getUserConfig() -> UserConfig? { | ||
| return userConfigQueue.sync { [weak self] in |
There was a problem hiding this comment.
are there any tests we can add to check that getting/setting this data across multiple threads is safe?
jsalaber
force-pushed
the
fix-setting-user-config-multiple-threads
branch
from
91ddf8d to
f46854e
Compare
jonathannorris
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
DispatchQueueto synchronize setting and getting user configs to prevent issue where thread is accessing a garbage collected userConfig