[Lint] Run `ruff check -fix` and `format` on main branch by tovaz92 · Pull Request #2784 · DestinE-Climate-DT/AQUA

tovaz92 · 2026-03-20T15:02:51Z

The first step towards the integration of the changes from ruff, is to run check -fix and format on the main.

Link also to: #2738

Changelog is updated.

and open pr

codecov · 2026-03-20T16:33:35Z

❌ 45 Tests Failed:

Tests completed	Failed	Passed	Skipped
508	45	463	1

View the top 1 failed test(s) by shortest run time

tests/test_gsv.py::TestGsv::test_reader_polytope_mn5@dask_operations

Stack Traces | 300s run time

self = <test_gsv.TestGsv object at 0x7f501c612210>

    def test_reader_polytope_mn5(self) -> None:
        """
        Reading from mn5 databridge using polytope
        """
        reader = Reader(
            catalog="climatedt-o25.1",
            model="IFS-NEMO",
            exp="historical-1990",
            source="hourly-hpz7-atm2d",
            startdate="19900101T0000",
            enddate="19910101T0025",
            loglevel="debug",
            engine="polytope",
            areas=False,
        )
>       data = reader.retrieve(var="2t")
               ^^^^^^^^^^^^^^^^^^^^^^^^^

tests/test_gsv.py:322: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.../core/reader/reader.py:439: in retrieve
    data = self.reader_fdb(self.esmcat, loadvar, startdate, enddate, dask=True, level=level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.../core/reader/reader.py:1051: in reader_fdb
    ).to_dask()
      ^^^^^^^^^
.../core/gsv/intake_gsv.py:737: in to_dask
    self._load_metadata()
.../aqua/lib/python3.12.../intake/source/base.py:283: in _load_metadata
    self._schema = self._get_schema()
                   ^^^^^^^^^^^^^^^^^^
.../core/gsv/intake_gsv.py:530: in _get_schema
    self._ds = self._get_partition(0, var=self._var, first=True, onelevel=self.onelevel)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.../core/gsv/intake_gsv.py:693: in _get_partition
    dataset = gsv.request_data(
.../aqua/lib/python3.12....../site-packages/gsv/retriever.py:530: in request_data
    self.datareader = self._retrieve(request)
                      ^^^^^^^^^^^^^^^^^^^^^^^
.../aqua/lib/python3.12....../site-packages/gsv/retriever.py:228: in _retrieve
    return self.engine.retrieve(mars_request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.../aqua/lib/python3.12.../gsv/engines/polytope_engine.py:46: in retrieve
    self.polytope_client.retrieve(
.../aqua/lib/python3.12.../polytope/api/helpers.py:197: in decorated
    return fun(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
.../aqua/lib/python3.12.../polytope/api/helpers.py:229: in decorated
    return method(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.../aqua/lib/python3.12.../polytope/api/helpers.py:197: in decorated
    return fun(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
.../aqua/lib/python3.12.../polytope/api/Client.py:202: in retrieve
    return self.request_manager.retrieve(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.../aqua/lib/python3.12.../polytope/api/RequestManager.py:354: in retrieve
    response, response_messages = helpers.try_request(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

method = 'post', situation = 'trying to submit a retrieval request'
expected = [200, 202, 204], logger = <Logger polytope.api.Client.WDBOSF (DEBUG)>
stream = True, skip_tls = False, session = None
kwargs = {'headers': {'Authorization': 'Bearer eyJhbGciOiJIUzUxMiIsInR5cCIgOiAiSldUIiwia2lkIiA6ICJhOGRkMTE5Yy1kYjg0LTQ1ZGItODJi...'verb': 'retrieve'}, 'url': 'https://polytope.mn5.apps.dte.destination-earth.eu:.../v1/requests/destination-earth'}
url = 'https://polytope.mn5.apps.dte.destination-earth.eu:.../v1/requests/destination-earth'
verify = True
request_content = {'headers': {'Authorization': 'Bearer eyJhbGciOiJIUzUxMiIsInR5cCIgOiAiSldUIiwia2lkIiA6ICJhOGRkMTE5Yy1kYjg0LTQ1ZGItODJi...param:\n- '167'\nrealization: 1\nresolution: standard\nstream: clte\ntime:\n- '0000'\ntype: fc\n", 'verb': 'retrieve'}}
retriable = <function try_request.<locals>.retriable at 0x7f501388d080>
attempt = 4, max_attempts = 10, sleep = 120

    def try_request(method, situation, expected, logger, stream=False, skip_tls=False, session=None, **kwargs):
        url = kwargs.get("url", None)
        verify = not skip_tls
        request_content = {"headers": kwargs.get("headers", None), "json": kwargs.get("json", None)}
    
        def retriable(code):
            if code in [
                requests.codes.internal_server_error,
                requests.codes.bad_gateway,
                requests.codes.service_unavailable,
                requests.codes.gateway_timeout,
                requests.codes.too_many_requests,
                requests.codes.request_timeout,
            ]:
                return True
            return False
    
        attempt = 1
        max_attempts = 10
        sleep = 120
        success = False
        while attempt <= max_attempts:
            try:
                if session is None:
                    method_to_call = getattr(requests, method)
                else:
                    method_to_call = getattr(session, method)
    
                logger.debug("Polytope client attempting HTTP " + method.upper() + " " + url + "\n" + str(request_content))
                response = method_to_call(**kwargs, verify=verify, stream=stream)
            except requests.exceptions.ConnectionError as e:
                response = None
                message = "Recovering from connection error."
                message += "\n" + str(e)
                logger.warning(message)
    
            if response is not None:
                if retriable(response.status_code):
                    message = (
                        "Recovering from HTTP error ("
                        + str(response.status_code)
                        + ": "
                        + requests.status_codes._codes[response.status_code][0]
                        + ")"
                    )
                    logger.warning(message)
                else:
                    success = True
                    break
    
            logger.info("Attempt " + str(attempt) + " of " + str(max_attempts))
            logger.info("Next retry in " + str(sleep) + " seconds")
            attempt = attempt + 1
>           time.sleep(sleep)
E           Failed: Timeout (>300.0s) from pytest-timeout.

.../aqua/lib/python3.12.../polytope/api/helpers.py:591: Failed

View the full list of 44 ❄️ flaky test(s)

tests/test_timstat.py::TestTimmean::test_timmax_daily[long-2t]@dask_operations

Flake rate in main: 8.57% (Passed 32 times, Failed 3 times)