[Lint] Use ruff formatter and pre-commit framework#2748
Open
[Lint] Use ruff formatter and pre-commit framework#2748
ruff formatter and pre-commit framework#2748Conversation
…t (also in github actions reusable)
tovaz92
added a commit
to DestinE-Climate-DT/AQUA-diagnostics
that referenced
this pull request
Mar 6, 2026
4 tasks
Collaborator
Author
|
After a chat with the group, we will go for Ruff as it is much more flexible for our needs. |
black formatter and pre-commit frameworkruff formatter and pre-commit framework
oloapinivad
reviewed
Mar 11, 2026
Collaborator
Author
|
ok, the action seems to behave as we expected. It is failing and showing all the problems. I am tempted to exclude the |
Collaborator
Author
|
Just tested pre-commit locally following the steps in this PR description/intallation |
oloapinivad
reviewed
Mar 16, 2026
oloapinivad
reviewed
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aim to:
flake8linter withrufflinter-formatterpre-commitNote once pre-commit is installed:
pre-commit-hookswill run:trailing-whitespace,end-of-file-fixer,check-yamland will run on all committed filesruff-pre-commitwill run:ruff-check,ruff-format(only on .py files).Installation:
Follow steps below to make pre-commit operative:
pip install -e ".[precommit]"(otherwise if the user want to install aqua withenvironment.yml, uncomment the relative line)pre-commit installpre-commit uninstallor, if want to temporarily "switch-off" (need to be reinstalled after the unchecked push):Issues closed by this pull request:
Close #2738