Automatically initialize regridders with loaded weights in the Regridder class#2700
Automatically initialize regridders with loaded weights in the Regridder class#2700
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2700 +/- ##
=======================================
Coverage 74.01% 74.01%
=======================================
Files 80 80
Lines 7680 7681 +1
Branches 1494 1494
=======================================
+ Hits 5684 5685 +1
Misses 1486 1486
Partials 510 510
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Hi @jhardenberg could you check if you find any problem in this additional step? |
|
The reason why the initialization of the regridders was delayed in the The example should be fixed anyway, because We could either just change the docs saying that one needs to call initialize after computing the weights (but I admit that for a user this looks complicated) or introduce a 'double' behaviour of the |
Maybe this can be discussed on monday if there is extra time, I have no problem in calling explicitly the initialize method but indeed I'm not a beginner user and the documentation was wrong about this specific case. |
|
Add |
PR description:
I tested a Regridder alone workflow such as:
In the current implementation it gives error:
This because the self.initialize method is not used. I can add it manually in my code but this is exactly the example from the documentation so I think a fix should be inserted in the code and this is what I am proposing
People involved:
@oloapinivad