Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Configurable email subject prefix #1307

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

leec94
Copy link
Contributor

@leec94 leec94 commented Jun 6, 2024

Description

porting issue DependencyTrack/dependency-track#3422

Addressed Issue

for porting issues #1190

Additional Details

need to port corresponding front end issue too DependencyTrack/frontend#720

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@leec94 leec94 force-pushed the port-issue-3422 branch from 84e53d2 to f460fb0 Compare June 6, 2024 15:11
Signed-off-by: leec94 <[email protected]>
Co-authored-by: Andres Tito <[email protected]>
Co-authored-by: Andres Tito <[email protected]>
Signed-off-by: leec94 <[email protected]>
@nscuro nscuro added enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base labels Jun 6, 2024
@nscuro nscuro added this to the 0.5.0 milestone Jun 6, 2024
Co-authored-by: Andres Tito <[email protected]>
Signed-off-by: leec94 <[email protected]>
@leec94
Copy link
Contributor Author

leec94 commented Jun 6, 2024

i'm done fussing with this now, should be ready now for review + everything. you're so fast @nscuro 😆

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+2.67% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6c774d4) 172 140 81.40%
Head commit (11f944f) 6741 (+6569) 5667 (+5527) 84.07% (+2.67%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1307) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@leec94
Copy link
Contributor Author

leec94 commented Jun 6, 2024

@nscuro the corresponding frontend issue https://github.com/DependencyTrack/frontend/pull/720/files is already in hyades-frontend repo. if there's a table for front end issues to port, you can mark this as already done

@nscuro
Copy link
Member

nscuro commented Jun 6, 2024

@leec94 Thanks for the heads-up, I think that may be because hyades-frontend was forked sometime between DT v4.10 and v4.11. Looks like we already have some v4.11 changes in there...

@nscuro nscuro merged commit a75b030 into DependencyTrack:main Jun 6, 2024
13 checks passed
@leec94 leec94 deleted the port-issue-3422 branch June 7, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants