Merge pull request #727 from nscuro/fix-redundant-request

Fix table column visibility preferences triggering redundant requests
DependencyTrack · Feb 3, 2024 · 22371f5 · 22371f5
2 parents 883b651 + ff44ac3
commit 22371f5
Showing 1 changed file with 17 additions and 1 deletion.
diff --git a/src/shared/utils.js b/src/shared/utils.js
@@ -72,8 +72,24 @@ export function getContextPath() {
 }
 
 export function loadUserPreferencesForBootstrapTable(_this, id, columns) {
+  const table = _this.$refs.table;
+  if (!table) {
+    console.error("No table defined in the calling component; Can't apply user preferences");
+    return;
+  }
+
   columns.forEach((column) => {
-    _this.$set(column, "visible", (localStorage && localStorage.getItem(id + "Show" + common.capitalize(column.field)) !== null) ? (localStorage.getItem(id + "Show" + common.capitalize(column.field)) === "true") : column.visible);
+    const isVisible = column.visible;
+    const shouldShow = (localStorage && localStorage.getItem(id + "Show" + common.capitalize(column.field)) !== null)
+      ? (localStorage.getItem(id + "Show" + common.capitalize(column.field)) === "true")
+      : isVisible;
+    if (isVisible !== shouldShow) {
+      if (shouldShow) {
+        table.showColumn(column.field);
+      } else {
+        table.hideColumn(column.field);
+      }
+    }
   })
 }