-
-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for mirroring of the NVD via API #3175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Makes debugging and evaluating test failures easier. Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to mirror the NVD through its API v2.0, in response to the NVD's plan to retire the file-based vulnerability feeds.
Usage of the API will be initially optional, as using it without prior configuration of an API key will make users subject to aggressive rate limiting, which in turn causes mirroring to take a long time.
Downloading of feed files can optionally be enabled in order to keep DT's internal file mirror up-to-date. This may help users with transitioning.
Mirroring of the entire NVD database with API key takes around 10min. This is also true when running on a system that previously mirrored the NVD via the legacy feeds.
Addressed Issue
Closes #1861
Partly addresses #2895
Additional Details
Frontend changes
DependencyTrack/frontend#642
Observed differences in mirrored data
NistMirrorTask
, or the NVD simply provides more data via their API.Non-functional changes
Vulnerability
andVulnerableSoftware
, as well asAffectedVersionAttribution
records with the database is now properly transactional. There is now one transaction for synchronizing theVulnerability
record, and one for synchronizingVulnerableSoftware
+AffectedVersionAttribution
.NistMirrorTask
which committed multiple transactions per synchronization operation.NistMirrorTask
.NistMirrorTask
appears to be creating duplicate entries in theVULNERABLESOFTWARE_VULNERABILITIES
table. This is dealt with and automatically cleaned up by the new API-basedNistApiMirrorTask
.Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR introduces changes to the database model, and I have added corresponding update logic