Fix/bug nodata datacatalog export #1331
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hboisgon
reviewed
Dec 3, 2025
Comment on lines
+137
to
+140
| exec_nodata_strat( | ||
| handle_nodata, | ||
| f"Reading file(s) for {self.name} returned no data.", | ||
| ) |
Contributor
There was a problem hiding this comment.
Did you check the log? Feels like we might be warning twice? Already in read_data just above and now here again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Encountered a bug with exporting artifact data with the datacatalog.export_data method.
If no data is found within the given bounding box the export_data method will break instead of handle the no data.
I also saw that some logging and error messaging in the drivers was not properly working. I improved that as well.
Explanation
Explain how you addressed the bug/feature request, what choices you made and why.
General Checklist
mainData/Catalog checklist
data/catalogs/predefined_catalogs.ymlhas not been modified.data_catalog.ymlfiles have been changeddata/changelog.rsthas been updatedLFline endings (done automatically if you usedupdate_versions.py)Additional Notes (optional)
Add any additional notes or information that may be helpful.