Skip to content

Conversation

@Tjalling-dejong
Copy link
Contributor

Issue addressed

Fixes #

Explanation

Explain how you addressed the bug/feature request, what choices you made and why.

General Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation
  • Updated changelog.rst

Data/Catalog checklist

  • data/catalogs/predefined_catalogs.yml has not been modified.
  • None of the old data_catalog.yml files have been changed
  • data/changelog.rst has been updated
  • new file uses LF line endings (done automatically if you used update_versions.py)
  • New file has been tested locally
  • Tests have been added using the new file in the test suite

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@Tjalling-dejong Tjalling-dejong marked this pull request as ready for review November 25, 2025 15:37
@sonarqubecloud
Copy link

@deltamarnix
Copy link
Contributor

This looks like a workaround for what PR #1282 is doing. We should have a talk with @savente93 on the release process with RCs. I want to keep the release branches open, and the merge should be a normal merge, no squash, for example. But there might be other things to consider, like the release notes and upgrading the version.

@savente93
Copy link
Contributor

Yeah, more needs to be done if we're releasing the final version of 1.3 than just bumping the number. I'll be happy to rework the release process to handle RCs and the best practices of the memo. I'm not sure if we want to wait for that thought to do this release, since that will take some more time. What do you want to do for now @deltamarnix ?

@Tjalling-dejong
Copy link
Contributor Author

Its not a workaround. I only bumped the version to 1.3.0dev. we are currently working on 1.3.0, so the dev version shoudl reflect that right?

@deltamarnix
Copy link
Contributor

You are right, but #1282 already does that and there is more to handle than just the version number. Also the release notes and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants