Skip to content

Conversation

@robin-deltares
Copy link
Contributor

This pull request updates the Windows test environment setup for the Delft3D project. The main focus is on improving how the deltares_testbench directory and its dependencies are handled in both Docker and TeamCity build scripts, ensuring a more consistent and maintainable workflow.

The goal is to see if flaky tests become stable when the case directories are inside the container file system instead of mounted through a --bind mount.

Testbench directory and dependency management:

  • The entire deltares_testbench directory is now copied into the test environment instead of just the requirements file, ensuring all necessary files are available for testing.
  • The Dockerfile now adds the full deltares_testbench directory and installs Python dependencies directly from its pip/win-requirements.txt, simplifying dependency management.

Build and test configuration updates:

  • The working directory for running TestBench.py in TeamCity is changed to the root of the testbench (C:\deltares_testbench) for consistency with the new directory structure.
  • Docker run parameters now include a volume mount to ensure engine data is available inside the container, improving test reliability.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the Windows test environment setup to copy the entire deltares_testbench directory into the Docker container rather than mounting it, aiming to improve test stability by avoiding potential issues with bind mounts.

  • The entire deltares_testbench directory is now copied into both the TeamCity environment and Docker container instead of just the requirements file
  • The working directory for TestBench.py is changed to point to the container's internal path (C:\deltares_testbench)
  • A volume mount is added to the Docker run parameters to provide access to engine data

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
ci/teamcity/Delft3D/windows/testEnvironment.kt Changes from copying only win-requirements.txt to recursively copying the entire deltares_testbench directory
ci/teamcity/Delft3D/windows/test.kt Updates working directory to container path and adds volume mount for engine data in Docker run parameters
ci/dockerfiles/windows/Dockerfile-dhydro-test-environment Modifies Dockerfile to add entire deltares_testbench directory and install dependencies from its internal path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@robin-deltares robin-deltares changed the title All/task/devopsdsc 829 test windows testbench container without mount DEVOPSDSC-829 Windows testbenches in container without mounted case folders Dec 2, 2025
@robin-deltares
Copy link
Contributor Author

Blocker: artifacts (of results) are inside the container and are not available to TeamCity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants