Part/feature/part 228 accept sigma z via keyword #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By inserting an extra keyword, the user can use sigma-z-layer configurations, even though they are not fully supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done
When implementing the keyword (being true) the block is removed and the model should run with combined sigma/z-layer models.
A warning will be needed that this is only valid for certain situations (in particular it should not be possible for this domain for particles to move from the z-layer section in the vertical to a sigma-layer section (or vice-versa), and that this option should be used with care.
This option needs to be documented and limitations and/or implications should be included
A continuation issue will be created to fix this in a more definitive way.
Evidence of the work done
Clear from the issue description
Tests
Add a testcase in P drive. We don't know if thif function will be support in the standard version, therefore the testcase will be added to teamcity.
Documentation
Documentation updated
Issue link