Skip to content

Conversation

@BartSteurDeltares
Copy link
Contributor

@BartSteurDeltares BartSteurDeltares commented Nov 20, 2025

To both the windows and linux collectors I upload the artifacts to nexus as well as still on teamcity. Then in the build configs that need those artifacts I download those artifacts from Nexus. The recipes are used to upload/download for linux and windows.

@BartSteurDeltares BartSteurDeltares marked this pull request as ready for review November 20, 2025 13:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements artifact management through Nexus repository for both Windows and Linux build pipelines. The changes enable uploading build artifacts to Nexus during the collect phase and downloading them in subsequent build configurations, while maintaining backward compatibility with TeamCity artifacts.

Key Changes:

  • Added Nexus credentials configuration to project settings
  • Implemented artifact upload steps in Linux and Windows collect build types
  • Implemented artifact download steps in test and runtime container build types

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
ci/teamcity/Delft3D/settings.kts Added Nexus username and password parameters for authentication
ci/teamcity/Delft3D/windows/collect.kt Added PowerShell step to create zip archive and Nexus upload step for Windows artifacts
ci/teamcity/Delft3D/windows/test.kt Added Nexus download step and disabled extraction logic for Windows test artifacts
ci/teamcity/Delft3D/linux/collect.kt Added script to create tar.gz archive and Nexus upload step for Linux artifacts
ci/teamcity/Delft3D/linux/unitTest.kt Added Nexus download step and disabled extraction logic for Linux unit test artifacts
ci/teamcity/Delft3D/linux/runtimeContainers.kt Added Nexus download step and disabled extraction logic for Linux runtime container artifacts

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BartSteurDeltares BartSteurDeltares marked this pull request as draft November 27, 2025 07:33
@BartSteurDeltares BartSteurDeltares self-assigned this Nov 27, 2025
@BartSteurDeltares BartSteurDeltares marked this pull request as ready for review November 27, 2025 10:20
@matthijs-deltares
Copy link
Contributor

Can be merged once the clean-up is arranged. In order to get this working dimitri needs to update the server application.

@matthijs-deltares
Copy link
Contributor

Can you create a follow up task to enable the artefact from nexus instead of TC with in the description that it can be done once we give nexus the prodcution ready stamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants