Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm32-wasip1/wasm32-wasip2 tests #441

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

lastmjs
Copy link

@lastmjs lastmjs commented Mar 8, 2025

This PR enables as many of the automated CI test suite as possible for the wasm32-wasip1 and wasm32-wasip2 targets.

@lastmjs lastmjs changed the title Wasm32 wasip1 wasip2 tests wasm32-wasip1/wasm32-wasip2 tests Mar 8, 2025
@lastmjs
Copy link
Author

lastmjs commented Mar 8, 2025

I'm opening up this draft to get some feedback. Most of the test suite from .github/workflows/ci.yml is passing. But there are 13 tests from Doc-tests rquickjs_core that aren't running. I'd like some guidance on if these Doc-tests would be valuable to run, and if we should figure out some way to get this to run. My feeling after my current round of R&D for this would be that Doc-tests aren't really possible to run on wasm32 targets, and that it would be more practical to extract those tests and run them normally, if the test coverage for those tests is desirable.

@DelSkayn
Copy link
Owner

DelSkayn commented Mar 13, 2025

I personally see doc tests as testing for the validity of examples given in the docs, ensuring the code there actually runs.
Useful to test for but not really necessary to run on every platform.

They shouldn't contribute meaningfully to coverage, and if they do then we should introduce non-doc tests to also provide the same coverage.

@lastmjs lastmjs marked this pull request as ready for review March 15, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants